RFR: 8212961: [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup [v2]

[David Holmes]

> Please review what is primarily a code style cleanup with some old native code:
> 
> - add spaces around operators and after commas
> - fixed indent and line breaks
> - added braces to blocks
> - replaced raw malloc with c_malloc (check malloc)
> - fixed CE macro using and exception processing in general
>   - added different CHECK macro for monitor enter/exit
>   - removed some unreachable explicit exception checking code
> 
> I staged this as multiple commits to try and make the changes more obvious at each step (and if you hide whitespace changes it simplifies quite a bit), but it may be easier to just look at the end results and see if anything jumps out as still needing changing.
> 
> Note: there was no attempt to actually change the logic of any test or rewrite them in a better way - that is out of scope for the cleanup. The only logic changes relates to the CE macro and exception/error checking.
> 
> Testing:
> - local running of the tests themselves
> - tier5 testing in our CI system (in progress).
> 
> This may be of interest to @iignatev  and @lmesnik .
> 
> Thanks,
> David

David Holmes has updated the pull request incrementally with one additional commit since the last revision:

  Restored 'dead code' that led to compilation failure on Windows

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4882/files
  - new: https://git.openjdk.java.net/jdk/pull/4882/files/64ae394c..aa3c5c89

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4882&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4882&range=00-01

  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4882.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4882/head:pull/4882

PR: https://git.openjdk.java.net/jdk/pull/4882