RFR: 8269523: runtime/Safepoint/TestAbortOnVMOperationTimeout.java failed when expecting 'VM operation took too long'
David Holmes
dholmes at openjdk.java.net
Mon Jul 26 21:38:31 UTC 2021
On Mon, 26 Jul 2021 00:23:43 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Please review this simple test adjustment:
> - dropped 5ms timeout as we have seen execution as low as 2ms
> - enabled GC logging
> - report output in all cases to allow ease of analysis
>
> Testing: ran 10x on macos/linux/Windows x64 and macos Aarch64 to check execution times and adjusted test accordingly
>
> Thanks,
> David
Hi Aleksey,
I think both those suggestions make the test more robust, but I don't think they can really be the cause of any failures unless there is some really obscure non-determinism involved. The behaviour of the SerialGC should not vary - it either always does a young GC or never. The JIT optimisation could vary on different runs depending on flags but we don't observe that either - the very short VM ops occur under the same settings as the not short VMops.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4901
More information about the hotspot-runtime-dev
mailing list