Integrated: 8212961: [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup

[David Holmes]

On Thu, 22 Jul 2021 22:42:20 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review what is primarily a code style cleanup with some old native code:
> 
> - add spaces around operators and after commas
> - fixed indent and line breaks
> - added braces to blocks
> - replaced raw malloc with c_malloc (check malloc)
> - fixed CE macro using and exception processing in general
>   - added different CHECK macro for monitor enter/exit
>   - removed some unreachable explicit exception checking code
> 
> I staged this as multiple commits to try and make the changes more obvious at each step (and if you hide whitespace changes it simplifies quite a bit), but it may be easier to just look at the end results and see if anything jumps out as still needing changing.
> 
> Note: there was no attempt to actually change the logic of any test or rewrite them in a better way - that is out of scope for the cleanup. The only logic changes relates to the CE macro and exception/error checking.
> 
> Testing:
> - local running of the tests themselves
> - tier5 testing in our CI system (in progress).
> 
> This may be of interest to @iignatev  and @lmesnik .
> 
> Thanks,
> David

This pull request has now been integrated.

Changeset: fde18313
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/fde183130bc6379fe0d4624bbeaf252d0e9a15c8
Stats:     777 lines in 8 files changed: 111 ins; 121 del; 545 mod

8212961: [TESTBUG] vmTestbase/nsk/stress/jni/ native code cleanup

Reviewed-by: stuefe, iignatyev

-------------

PR: https://git.openjdk.java.net/jdk/pull/4882