RFR: 8269523: runtime/Safepoint/TestAbortOnVMOperationTimeout.java failed when expecting 'VM operation took too long' [v2]

[Aleksey Shipilev]

On Mon, 26 Jul 2021 23:32:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this simple test adjustment:
>>  - dropped 5ms timeout as we have seen execution as low as 2ms
>>  - enabled GC logging
>>  - report output in all cases to allow ease of analysis
>> 
>> Testing: ran 10x on macos/linux/Windows x64 and macos Aarch64 to check execution times and adjusted test accordingly
>> 
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Robustness suggestions from @shipilev

That's fine, thanks for trying. I have a minor suggestion.

test/hotspot/jtreg/runtime/Safepoint/TestAbortOnVMOperationTimeout.java line 40:

> 38: 
> 39:     // A static array is unlikely to be optimised away by the JIT.
> 40:     static Object[] arr = new Object[10_000_000];

Initialization should be under `args.length > 0` check. We don't need it in the driver code.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4901