[jdk17] RFR: 8271174: runtime/ClassFile/UnsupportedClassFileVersion.java can be run in driver mode

Igor Ignatyev iignatyev at openjdk.java.net
Tue Jul 27 23:21:33 UTC 2021


On Fri, 23 Jul 2021 01:30:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this trivial patch that switches execution mode in `runtime/ClassFile/UnsupportedClassFileVersion.java` test to `driver`?
>> 
>> testing: `runtime/ClassFile/UnsupportedClassFileVersion.java` on `{linux,windows,macos}-x64`
>> 
>> Thanks,
>> -- Igor
>
> test/hotspot/jtreg/runtime/ClassFile/UnsupportedClassFileVersion.java line 30:
> 
>> 28:  *          java.base/jdk.internal.misc
>> 29:  *          java.management
>> 30:  * @compile -XDignore.symbol.file UnsupportedClassFileVersion.java
> 
> I can't find what -XDignore.symbol.file was used for, so am unsure if removing it is in fact okay in all circumstances. ??

I believe we had to have it b/c we used JDK internal API, i.e. asm, now we have corresponding `@modules` tags, and `-XDignore.symbol.file` isn't need anymore. also, it's used at `@compile`, so if it is required, the test would fail fast and (largely) independently from JVM configurations.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/276


More information about the hotspot-runtime-dev mailing list