RFR: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared [v2]

[David Holmes]

On 1/06/2021 9:25 pm, Jie Fu wrote:
> On Tue, 1 Jun 2021 10:48:24 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> 
>> Hi, on newer s390x machines (SLES15.2) the value of SYS_get_mempolicy is 269 .
>> So a fix value per platform is not always correct.
>> However we have the define for SYS_get_mempolicy on this SLES15.2 machine.
> 
> Okay.
> Patch has been updated to check & try to use __NR_get_mempolicy first if SYS_get_mempolicy is not defined, which is suggested by @TheRealMDoerr in the JBS.

I don't see that suggestion in the JBS. I do see a greatly simplified 
suggestion from mbaesken:

#if !defined(SYS_get_mempolicy) && defined(S390)
#define SYS_get_mempolicy __NR_get_mempolicy
#endif

If we know that __NR_get_mempolicy is defined on the system that had the 
problem then we don't need to try and generalize things - specially if 
the actual value is not constant for a given architecture.

Thanks,
David

> Thanks.
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4277
>