RFR: JDK-8267839: trivial mem leak in numa

Stefan Johansson sjohanss at openjdk.java.net
Tue Jun 1 12:47:20 UTC 2021


On Thu, 27 May 2021 08:46:00 GMT, Hamlin Li <mli at openjdk.org> wrote:

> There is a trivial mem leak in numa related code. This patch is to use a stored bitmask* rather than get a new one.

The change looks good. 

I know this pre-existing, but to me it feels a bit strange to return false if the NUMA-functions are available. Wouldn't it make more sense to return true, which would disable NUMA. This is not something we should change in this patch, just wanted to hear others opinions now when I stumbled upon this.

-------------

Marked as reviewed by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4219


More information about the hotspot-runtime-dev mailing list