RFR: 8266557: assert(SafepointMechanism::local_poll_armed(_handshakee)) failed: Must be [v3]

Daniel D.Daugherty dcubed at openjdk.java.net
Tue Jun 1 21:30:41 UTC 2021


On Tue, 1 Jun 2021 19:23:44 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into handshakee
>>  - Small update
>>  - Merge branch 'master' into handshakee
>>  - Fix
>
> src/hotspot/share/runtime/handshake.cpp line 330:
> 
>> 328:   // closure are visible to the VMThread/Handshaker after it reads
>> 329:   // that the operation has completed.
>> 330:   Atomic::dec(&_pending_threads);
> 
> Why do we need a full fence instead of a release as before?

And does the comment on L326 now need to be updated?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3973


More information about the hotspot-runtime-dev mailing list