RFR: 8267958: [TESTBUG] cds DynamicLoaderConstraintsTest.java timed out

Calvin Cheung ccheung at openjdk.java.net
Tue Jun 1 23:16:31 UTC 2021


On Tue, 1 Jun 2021 19:35:35 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> [JDK-8267347](https://bugs.openjdk.java.net/browse/JDK-8267347) doubles the amount of time spent inside this test. It's better to split the test into two parts as suggested by @iignatev in https://github.com/openjdk/jdk/pull/4198#discussion_r641343393

Looks good. Couple of nits below.

test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java line 43:

> 41:  * @requires vm.cds.custom.loaders
> 42:  * @summary Test class loader constraint checks for archived classes (dynamic archive) with custom class loader
> 43:  * @bug 8267347

Please also add the current bug id.

test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/LoaderConstraintsTest.java line 40:

> 38:  * @requires vm.cds.custom.loaders
> 39:  * @summary Test class loader constraint checks for archived classes with custom class loader
> 40:  * @bug 8267347

You've omitted the 8267754 bug id. Please also add the current bug id.

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4287


More information about the hotspot-runtime-dev mailing list