RFR: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared [v2]

[David Holmes]

On Tue, 1 Jun 2021 11:21:41 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review the patch which fixes the build failure on SUSE Linux Enterprise Server 11.4 (s390x).
>> 
>> @dholmes-ora had reminded me of this bug in [1].
>> But I missed the fact that ZGC is currently only built on x64 and aarch64.
>> And I'm sorry for this breakage.
>> 
>> The sys_call numbers of get_mempolicy for different platforms are just copied from the libnuma source code [2].
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>> 
>> [1] https://github.com/openjdk/jdk/pull/4205#discussion_r639708293
>> [2] https://github.com/numactl/numactl/blob/master/syscall.c
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Check & try to use __NR_get_mempolicy first

I would prefer to only use what we need to fix the problem on the "old" system that it was observed rather than trying to generalize this for arbitrary/unknown old versions of Linux. Otherwise we can never know when it is okay to remove this code.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/4277