RFR: 8268014: Build failure on SUSE Linux Enterprise Server 11.4 (s390x) due to 'SYS_get_mempolicy' was not declared [v4]
Martin Doerr
mdoerr at openjdk.java.net
Wed Jun 2 13:24:40 UTC 2021
On Wed, 2 Jun 2021 11:28:46 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> Hi all,
>>
>> Please review the patch which fixes the build failure on SUSE Linux Enterprise Server 11.4 (s390x).
>>
>> @dholmes-ora had reminded me of this bug in [1].
>> But I missed the fact that ZGC is currently only built on x64 and aarch64.
>> And I'm sorry for this breakage.
>>
>> The sys_call numbers of get_mempolicy for different platforms are just copied from the libnuma source code [2].
>>
>> Thanks.
>> Best regards,
>> Jie
>>
>>
>> [1] https://github.com/openjdk/jdk/pull/4205#discussion_r639708293
>> [2] https://github.com/numactl/numactl/blob/master/syscall.c
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
>
> __NR_get_mempolicy may be also undefined
Right, `S390` is used in OS independent hotspot code. `__s390x__` comes from the linux headers. So, in os_linux, both macros can get used.
I'm fine with either version, but I'm not sure if only s390 is affected. I haven't heard from people who build zero on other platforms.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4277
More information about the hotspot-runtime-dev
mailing list