RFR: 8267926: AsyncLogGtest.java fails on assert with: decorator was not part of the decorator set specified at creation. [v3]

Xin Liu xliu at openjdk.java.net
Thu Jun 3 08:01:37 UTC 2021


On Mon, 31 May 2021 22:24:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Increase reader's counter before creating LogDecoration.
>
> src/hotspot/share/logging/logConfiguration.cpp line 267:
> 
>> 265:   //
>> 266:   // LogDecorator is a set of decorators represented in a uint. sizeof(uinit) is not greater than a machine word,
>> 267:   // so store of it is atomic on the mainstream processors. I.e. readers see either its older value or new value.
> 
> We should use Atomic::store and Atomic::load regardless.

I just comment out why it's MT-safe here. if it's necessary, we can use a new JBS issue to change it to Atomic::store.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4257


More information about the hotspot-runtime-dev mailing list