RFR: 8266557: assert(SafepointMechanism::local_poll_armed(_handshakee)) failed: Must be [v3]

Thu Jun 3 16:58:38 UTC 2021

On Thu, 3 Jun 2021 16:41:59 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Did you guys decide the comment needed updating or not?
>> I can't figure that out from the above.
>
> Maybe it should be added in the comment that the fence is also used to prevent removing of the operation to float above marking the operation as completed so we keep the invariant: "If the handshake operation is not completed it must be on at least one queue".

I still think we can keep the previous memory_order_release order, but if this stricter order makes it easier to read for others then I'm okay.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3973