RFR: 8267926: AsyncLogGtest.java fails on assert with: decorator was not part of the decorator set specified at creation. [v8]

Paul Hohensee phh at openjdk.java.net
Thu Jun 3 19:05:55 UTC 2021


On Thu, 3 Jun 2021 09:06:02 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> The root cause of the intermittent failure is that _decorators in LogDecorations 
>> may be inconsistent with LogOutput::_decorators. It could happen when gtest disables a
>> Log output via set_log_config(TestLogFileName, "all=off").
>> 
>> Since we copy the entire logDecorations, it's reasonable to copy _decorator as well. 
>> LogDecorator is a bitmask of uint. It's even smaller than a reference on LP64 platforms.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert back to the basic bugfix and remove AsyncLogGtest.java from ProblemList.

This makes sense. If _decorators is set to a reference to an ephemeral value, random memory stomps may ensue.

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4257


More information about the hotspot-runtime-dev mailing list