RFR: JDK-8268088: Clarify Method::clear_jmethod_ids() related comments in ClassLoaderData::~ClassLoaderData() [v2]

[Jiangli Zhou]

On Mon, 7 Jun 2021 11:22:59 GMT, Evgeny Astigeevich <github.com+42899633+eastig at openjdk.org> wrote:

>> Jiangli Zhou has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove whitespace.
>>  - Updated based on Evgeny's comments.
>
> src/hotspot/share/classfile/classLoaderData.cpp line 699:
> 
>> 697:   // Method::clear_jmethod_ids only sets the jmethod_ids to NULL without
>> 698:   // releasing the memory for related JNIMethodBlocks and JNIMethodBlockNodes.
>> 699:   // This is done intentionally because native code (e.g. JVMTI agent) obtains
> 
> Maybe rewriting to "native code (...) holding jmethod_ids may access..." would be clearer?

Updated as suggested. Thanks!

> src/hotspot/share/classfile/classLoaderData.cpp line 701:
> 
>> 699:   // This is done intentionally because native code (e.g. JVMTI agent) obtains
>> 700:   // jmethod_ids may access them after the associated classes and class loader
>> 701:   // are unloaded. The Java native Interface Specification says "method ID
> 
> "native" -> "Native"

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4383