RFR: 8266557: assert(SafepointMechanism::local_poll_armed(_handshakee)) failed: Must be [v6]

Robbin Ehn rehn at openjdk.java.net
Tue Jun 8 08:29:24 UTC 2021


On Mon, 7 Jun 2021 20:08:49 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> I did a crawl thru review of the v05 full webrev.
> Thumbs up.
> 
> There are a few copyright years that need to be updated.

Thank you!

> src/hotspot/share/utilities/filterQueue.hpp line 68:
> 
>> 66:   // exclusive to other contains and pops calls.
>> 67:   template <typename MATCH_FUNC>
>> 68:   bool contains(MATCH_FUNC& match_func);
> 
> Need to update the copyright for this file.

Fixed

> src/hotspot/share/utilities/filterQueue.inline.hpp line 114:
> 
>> 112:   } while (true);
>> 113: }
>> 114: 
> 
> Need to update the copyright for this file.

Fixed

> test/hotspot/gtest/utilities/test_filterQueue.cpp line 58:
> 
>> 56: static void is_empty(FilterQueue<uintptr_t>& queue) {
>> 57:   EXPECT_EQ(queue.is_empty(), true) << "Must be empty.";
>> 58:   EXPECT_EQ(queue.contains(match_1), false) << "Must be empty.";
> 
> Need to update the copyright for this file.

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/3973


More information about the hotspot-runtime-dev mailing list