RFR: 8268165: AsyncLogging will crash if rotate() fails [v2]
Xin Liu
xliu at openjdk.java.net
Tue Jun 8 19:25:20 UTC 2021
On Fri, 4 Jun 2021 21:08:23 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> LogFileOutput::rotate() may leave _stream NULL because os::fopen() may return NULL due to space or inode limitations. AsyncLogWriter::write() calls LogFileOutput::write_blocking() without null check. Null check is added to prevent from crashing.
>
> Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8268165
> - 8268165: AsyncLogging will crash if rotate() fails
hi, David,
I see. I read through that wiki. I will stick with two-reviewers rules in the future.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4332
More information about the hotspot-runtime-dev
mailing list