RFR: 8267952: async logging supports to dynamically change tags and decorators

David Holmes dholmes at openjdk.java.net
Wed Jun 9 04:51:15 UTC 2021


On Tue, 8 Jun 2021 03:10:56 GMT, Xin Liu <xliu at openjdk.org> wrote:

> Support dynamic reconfiguration for async logging. 2 unittests are provided.
> The regression test discovers a race condition in LogTagSet::log() even with
> synchronous logging. It's not MT-safe if context switch happens between the
> creation of LogDecorations  and LogOutputList::Iterator. fixed.

src/hotspot/share/logging/logTagSet.cpp line 79:

> 77:   LogDecorations decorations(level, *this, _decorators);
> 78: 
> 79:   for (; it != _output_list.end(); it++) {

The reordering here needs a comment, else someone will be tempted to restore it to the original form.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4408


More information about the hotspot-runtime-dev mailing list