RFR: 8267954: Shared classes that failed to load should not be loaded again

[Yumin Qi]

On Wed, 9 Jun 2021 17:39:33 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> src/hotspot/share/classfile/systemDictionary.hpp line 84:
>> 
>>> 82: class TableStatistics;
>>> 83: 
>>> 84: class SharedClassLoadingMark {
>> 
>> I think it's better to put this class into systemDictionaryShared.hpp
>
> The move to systemDictionaryShared.hpp will cause zero build failed. We need a guard for CDS at:
> 1294     if (k != NULL) {
> 1295       SharedClassLoadingMark slm(THREAD, k);
> 1296       k = find_or_define_instance_class(class_name, class_loader, k, CHECK_NULL);
> 1297     }
> That makes the code looks fragmented. Do you agree to keep it not moved?

Maybe we should add guard here for shared code --- putting it to systemDictionaryShared.hpp is more reasonable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4434