RFR: 8268475: execute runtime/InvocationTests w/ -UseVtableBasedCHA

Igor Ignatyev iignatyev at openjdk.java.net
Wed Jun 9 18:53:13 UTC 2021


On Wed, 9 Jun 2021 18:42:57 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:

>> Hi all,
>> 
>> could you please review this small test-only patch?
>> from JBS:
>>> execution of runtime/InvocationTests w/ -XX:-UseVtableBasedCHA can be instrumental in finding bugs in the old implementation of CHA.
>> 
>> the patch adds a new test `invocationOldCHATests.java` which is based on `invocationC1Tests.java` but runs the tests w/ `-Xcomp -XX:+UnlockDiagnosticVMOptions -XX:-UseVtableBasedCHA`.
>> 
>> testing: `invocationOldCHATests.java` on `{linux,windows,macosx}-x64`
>> 
>> Thanks,
>> -- Igor
>
> test/hotspot/jtreg/runtime/InvocationTests/invocationOldCHATests.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2019, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> Since this is a new test, should this be just 2021, no 2019?

well, this file (and the majority of its code) is based on the file which was originated in 2019, hence I believe it should be 2019.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4438


More information about the hotspot-runtime-dev mailing list