RFR: 8267954: Shared classes that failed to load should not be loaded again [v3]

Yumin Qi minqi at openjdk.java.net
Wed Jun 9 21:28:33 UTC 2021


> Hi, Please review
>   Shared classes should not be loaded again at failed loading from CDS. In the failed case, restore_unshareable_info failed due to some reason (OOM), but the class already polluted and failed to be loaded again.
>   Using the unused bit in _misc_flags indicates shared loading status to prevent it from being loaded again.
> 
> Tests: tier1,tier2,tier3,tier4,tier7
> Local tests: jtreg/hotspot/runtime/cds
> TestDynamicDumpAtOom.java (which failed in tier7) with variant allocation sizes (used to reproduce the failure) passed.
> 
> Thanks
> Yumin

Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:

  Use CDS_ONLY for one line to replace INCLUDE_CDS

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4434/files
  - new: https://git.openjdk.java.net/jdk/pull/4434/files/4cb6d351..951c0fae

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4434&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4434&range=01-02

  Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4434.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4434/head:pull/4434

PR: https://git.openjdk.java.net/jdk/pull/4434


More information about the hotspot-runtime-dev mailing list