Integrated: 8267954: Shared classes that failed to load should not be loaded again

Yumin Qi minqi at openjdk.java.net
Wed Jun 9 21:38:16 UTC 2021


On Wed, 9 Jun 2021 16:24:42 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Hi, Please review
>   Shared classes should not be loaded again at failed loading from CDS. In the failed case, restore_unshareable_info failed due to some reason (OOM), but the class already polluted and failed to be loaded again.
>   Using the unused bit in _misc_flags indicates shared loading status to prevent it from being loaded again.
> 
> Tests: tier1,tier2,tier3,tier4,tier7
> Local tests: jtreg/hotspot/runtime/cds
> TestDynamicDumpAtOom.java (which failed in tier7) with variant allocation sizes (used to reproduce the failure) passed.
> 
> Thanks
> Yumin

This pull request has now been integrated.

Changeset: 7ff6e7b2
Author:    Yumin Qi <minqi at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/7ff6e7b2b1be088c37f50756b6822be01b4c657d
Stats:     72 lines in 7 files changed: 36 ins; 21 del; 15 mod

8267954: Shared classes that failed to load should not be loaded again

Reviewed-by: iklam, ccheung

-------------

PR: https://git.openjdk.java.net/jdk/pull/4434


More information about the hotspot-runtime-dev mailing list