RFR: 8268470: CDS dynamic dump asserts with JFR RecordingStream

Calvin Cheung ccheung at openjdk.java.net
Thu Jun 10 17:47:58 UTC 2021


On Thu, 10 Jun 2021 17:16:49 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> During JFR startup, it redefines some of the builtin classes like java/lang/Throwable. Later, when a subclass of Throwable is loaded, it will inherit the redefined version of Throwable which will not be inside the buffer space or mapped static archive.
>> 
>> To fix this bug, in `SystemDictionaryShared::check_for_exclusion_impl()`, instead of only checking if the class has been redefined, it also checks if any of its super types has been redefined. If so, exclude the class from the archive.
>> 
>> - [x] mach5 tier1, tier2 (including the new test)
>
> LGTM

@iklam Thanks for your review.
I'll withdraw the PR and rebase it on jdk17 since it is targeted for 17.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4467


More information about the hotspot-runtime-dev mailing list