[jdk17] RFR: 8268602: a couple runtime/os tests don't check exit code

Igor Ignatyev iignatyev at openjdk.java.net
Fri Jun 11 12:45:17 UTC 2021


On Fri, 11 Jun 2021 09:51:24 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this trivial and test-only patch that adds checks of exit code to two `runtime/os` tests?
> from JBS:
>> `runtime/os/TestUseCpuAllocPath.java` and `AvailableProcessors.java` spawn new JVMs but don't check their exit code which might lead to both type-I and type-II errors
> 
> testing: ``runtime/os` on `{linux,windows,macosx}-x64`
> 
> Thanks,
> -- Igor

thanks, David. I've moved `OutputAnalyzer::shouldHaveExitValue` calls. I agree that it makes sense to update ProcessTools API to always check exit code; I'll file an RFE for that.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/25


More information about the hotspot-runtime-dev mailing list