[jdk17] RFR: 8268522: InstanceKlass::can_be_verified_at_dumptime() returns opposite value [v2]

[Calvin Cheung]

On Sat, 12 Jun 2021 01:05:32 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change _is_shared_old_klass to _verified_at_dump_time
>
> src/hotspot/share/oops/instanceKlass.cpp line 2407:
> 
>> 2405:   if (!can_be_verified_at_dumptime()) {
>> 2406:     // Clear the _verified_at_dump_time bit.
>> 2407:     clear_verified_at_dump_time();
> 
> I think it's better to change this to 
> 
> 
> if (can_be_verified_at_dumptime()) {
>   // Remember this so we can avoid walking the hierarchy at runtime.
>   set_verified_at_dump_time();
> 
> 
> and do not set this bit inside `Klass::Klass()`. This way, all the code that changes this bit are kept in a single place.

Thanks Ioi.

I've pushed an update with your suggestion.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/31