RFR: 8267952: async logging supports to dynamically change tags and decorators

[Xin Liu]

On Mon, 14 Jun 2021 22:21:13 GMT, David Holmes <david.holmes at oracle.com> wrote:

> The updated branch passes the tier6 testing that previously failed. If
rotate() should not be being used by the test, yet the rotate() fix has
addressed the crashes, then apparently something else must be happening
here that is not fully understood.

Thanks for the feedback. To be honest, I am not sure what the root cause is.
I ran those two concurrent tests in hours as follows on different platforms, I have never seen a single crash. If I can have a reproducible, I will certainly figure out why and fix it. 

Now I intend to believe it's an external factor which caused it fails.  Those two tests don't trigger log rotation, but other gtests may do. Perhaps Oracle Linux mounts a small partition on /tmp.

My comment is like "a theory of operation". I try to document the original author's intention.  IMHO, it's thread-safe. 
Do you mind trying that patch again?  Maybe we were just lucky.


[ RUN      ] LogConfigurationTest.reconfigure_decorators_MT_vm
[       OK ] LogConfigurationTest.reconfigure_decorators_MT_vm (3601037 ms)
[ RUN      ] LogConfigurationTest.reconfigure_tags_MT_vm
[       OK ] LogConfigurationTest.reconfigure_tags_MT_vm (3600112 ms)


thanks,
--lx

-------------

PR: https://git.openjdk.java.net/jdk/pull/4408