RFR: 8267870: Remove unnecessary char_converter during class loading [v3]

Coleen Phillimore coleenp at openjdk.java.net
Wed Jun 16 02:25:56 UTC 2021


On Tue, 15 Jun 2021 22:41:58 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix CHECK_NULL.
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1313:
> 
>> 1311: 
>> 1312:     // Translate to external class name format, i.e., convert '/' chars to '.'
>> 1313:     Handle string = java_lang_String::externalize_classname(class_name, THREAD);
> 
> Should this be CHECK_NULL?

Yes, you're right.  I had some extra logging there at one point in this change history.  Thanks for finding that!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4173


More information about the hotspot-runtime-dev mailing list