RFR: 8267870: Remove unnecessary char_converter during class loading [v3]

Coleen Phillimore coleenp at openjdk.java.net
Wed Jun 16 12:45:39 UTC 2021


On Wed, 16 Jun 2021 02:25:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Because the new_symbol call will increment the Symbol* refcount in the SymbolTable, it's then copied to the java.lang.String, so the name isn't needed after this.
>
> Ah I see. The types were confusing me. We start with a char* convert to a Symbol, then convert that back to char* but with the externalized format. The irony there being that  it seems these Options start in external format but then get stored in internal format!
> No issue.

Yes, Ioi and I discussed this part of the change but since we substitute slashes for dots and then back again, it is correct.  Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/4173


More information about the hotspot-runtime-dev mailing list