RFR: 8268720: Unspecified checks on NameAndType constants should not be performed [v2]

[Harold Seigel]

On Wed, 16 Jun 2021 00:49:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updated comments, removed unneeded 'retur;'
>
> src/hotspot/share/classfile/classFileParser.cpp line 714:
> 
>> 712:             } else if (!Signature::is_void_method(signature)) { // must have void return
>> 713:               throwIllegalSignature("Method", name, signature, CHECK);
>> 714:               return;
> 
> So this is the check that is now skipped when doing the NameAndType_info check. In which case the comment should be expanded to something like:
> 
> " ... it must be <init\> and must have a void signature"
> 
> also the comment at line 697:
> 
> // Method name and signature are verified above, when iterating NameAndType_info.
> 
> may no longer be accurate.

Hi David, Thanks for reviewing this.  Please review this small update containing mostly comment changes.
Thanks, Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/4497