[jdk17] Integrated: 8268591: a few runtime/jni tests don't need `/othervm`
Igor Ignatyev
iignatyev at openjdk.java.net
Fri Jun 18 09:59:31 UTC 2021
On Fri, 11 Jun 2021 08:31:26 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> Hi all,
>
> could you please review this small and trivial patch that removes `/othervm` from 3 `runtime/jni` tests?
> from JBS:
>> `runtime/jni/registerNativesWarning/TestRegisterNativesWarning.java`, `checked/TestCheckedEnsureLocalCapacity.java`, and `atExit/TestAtExit.java` use `main/othervm` whereas in fact, they don't need `othervm`, and if we had CODETOOLS-7902658 implemented, they would have used `driver` mode. this RFE is to remove `/othervm`, so we at least won't waste time on creating a fresh JVM.
>
> the patch explicitly sets `-Djava.library.path=` for the child processes so they are able to locate native libraries.
>
> testing: `runtime/jni` on `{linux,windows,macosx}-x64`
>
> Thanks,
> -- Igor
This pull request has now been integrated.
Changeset: 59d84787
Author: Igor Ignatyev <iignatyev at openjdk.org>
URL: https://git.openjdk.java.net/jdk17/commit/59d84787e91e85dba4df45e99aa376f484e6ddff
Stats: 18 lines in 3 files changed: 8 ins; 1 del; 9 mod
8268591: a few runtime/jni tests don't need `/othervm`
Reviewed-by: dholmes, mseledtsov
-------------
PR: https://git.openjdk.java.net/jdk17/pull/18
More information about the hotspot-runtime-dev
mailing list