RFR: 8268720: Unspecified checks on NameAndType constants should not be performed [v2]

[Harold Seigel]

On Thu, 17 Jun 2021 18:54:33 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   updated comments, removed unneeded 'retur;'
>
> src/hotspot/share/classfile/classFileParser.cpp line 644:
> 
>> 642:             // Pass no_name so method name doesn't affect check for legal signature.
>> 643:             const Symbol* const no_name = vmSymbols::type_name(); // place holder
>> 644:             verify_legal_method_signature(no_name, sig, CHECK);
> 
> verify_legal_method_signature() has the potential to throw an exception.  Now it will have no name to include in that exception message concerning an illegal method signature.

Thanks Lois for finding this issue.

Please review commit 3 that restores passing the method name to verify_legal_method_signature() for use in exception messages and adds a flag parameter indicating if verify_legal_method_signature() should check if the method name and signature are compatible.

The change also adds a test case to check that the correct method name is in the exception message when verify_legal_method_signature() finds a bad method signature.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4497