RFR: 8256425: Obsolete Biased Locking in JDK 18 [v4]

[Patricio Chilano Mateo]

On Fri, 18 Jun 2021 18:00:59 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   restore run in EATests.java
>
> test/jdk/com/sun/jdi/EATests.java line 52:
> 
>> 50:  *                 -XX:+WhiteBoxAPI
>> 51:  *                 -Xbatch
>> 52:  *                 -XX:+DoEscapeAnalysis -XX:+EliminateAllocations -XX:-EliminateLocks -XX:+EliminateNestedLocks -XX:+UseBiasedLocking -XX:-UseOptoBiasInlining
> 
> I don't see this combination of flags in the new diff. I think the approach should be to remove the biased locking flags, and then remove any duplicate test runs that result from doing that.

Sorry I restored that run. I must have confused the +/- with the previous one.

> test/jdk/com/sun/jdi/EATests.java line 235:
> 
>> 233:         // Relocking test cases
>> 234:         new EARelockingSimpleTarget()                                                       .run();
>> 235:         new EARelockingSimple_2Target()                                                     .run();
> 
> I know all the tests that were removed mention biased locking in the comments, but do they require biased locking to function properly? I'm just wondering if we might get better EA test coverage if they are left in place.

They are trying to exercise some biased locking specific paths, but maybe @reinrich can comment on wether it is worth keeping them since he wrote the tests.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4522