RFR: 8268720: Unspecified checks on NameAndType constants should not be performed [v3]

[Harold Seigel]

On Mon, 21 Jun 2021 02:48:26 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add check_compatibility argument
>
> src/hotspot/share/classfile/classFileParser.hpp line 464:
> 
>> 462:   int  verify_legal_method_signature(const Symbol* methodname,
>> 463:                                      const Symbol* signature,
>> 464:                                      bool check_compatibility,
> 
> Can't help but think this method is trying to perform two jobs when it should only be doing one. What we previously considered "legal" is not actually a check of legality per-se as it is context specific. Perhaps this should really be split into two sets of checks?

Hi David, please review the latest commit that breaks verify_legal_method_signatures() into two functions, one that checks that the signature is legal, and the other, verify_legal_name_with_signature(), that checks that the method name and signature are compatible with each other.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4497