RFR: 8268720: Unspecified checks on NameAndType constants should not be performed [v4]

Harold Seigel hseigel at openjdk.java.net
Tue Jun 22 12:34:25 UTC 2021


On Tue, 22 Jun 2021 00:02:41 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   split verify_legal_method_signature() into two methods
>
> src/hotspot/share/classfile/classFileParser.cpp line 5058:
> 
>> 5056:     // make sure caller's args_size will be less than 0 even for non-static
>> 5057:     // method so it will be recomputed in compute_size_of_parameters().
>> 5058:     return;
> 
> The comment makes no sense with a void return type.

Thanks David!  I deleted the bogus comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4497


More information about the hotspot-runtime-dev mailing list