RFR: 8269135: TestDifferentProtectionDomains runs into timeout in client VM

[David Holmes]

On Tue, 22 Jun 2021 13:34:43 GMT, Christoph Göttschkes <cgo at openjdk.org> wrote:

> The test tries to compile a method using the WhiteBox with optimization level 4, which is not available in client VMs. The WhiteBox only prints out a warning, and the call to enqueueMethodForCompilation succeeds. After that, the test case goes into an endless loop to wait for the compilation to finish, which never happens, because the method is not enqueued for compilation.
> 
> I fixed this by choosing a different compilation level, if C2 is not included in the JVM. I think this test should be enough, since there is already an `@requires` which checks, that we are in mixed mode and that C2 should be used.
> 
> In addition, I bound the loop in order to fail with a timeout more early, if the compilation does not happen (or takes too long because of platform restrictions).

Hi Christoph,

I think, given the failure scenario the test is trying to test, that the best, and simplest, fix is to update the:

* @requires vm.compMode=="Xmixed" &
*           (vm.opt.TieredStopAtLevel == null | vm.opt.TieredStopAtLevel == 4)
 
so that it requires C2 to be present and so is skipped on a client-only VM.

Thanks,
David

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4558