RFR: JDK-8269206 A small typo in comment in test/lib/sun/hotspot/WhiteBox.java

Miao Zheng github.com+20216587+miao-zheng at openjdk.java.net
Wed Jun 23 08:48:25 UTC 2021


On Wed, 23 Jun 2021 07:19:04 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> return getMethodCompilationLevel(method, false /*not ost*/); 
>> 
>> "ost" should be "osr"
>
> Hi,
> 
> This is fine and trivial (ie only needs one reviewer and can be integrated immediately).
> 
> Normally such trivial matters are fixed when doing something else in that file - otherwise the overhead of performing the fix (JBS issue, PR, reviews) is just too much to be practical. In fact I recall seeing this typo (or a very similar one) fixed in a recent PR I was reviewing.
> 
> Thanks,
> David

@dholmes-ora Thanks for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4566


More information about the hotspot-runtime-dev mailing list