[jdk17] RFR: 8267952: async logging supports to dynamically change tags and decorators

[David Holmes]

On Thu, 24 Jun 2021 01:15:28 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> src/hotspot/share/logging/logAsyncWriter.cpp line 196:
>> 
>>> 194:       AsyncLogMessage token(nullptr, d, nullptr);
>>> 195: 
>>> 196:       // not disposable
>> 
>> I don't know what "not disposable" means.
>
> The reason I don't call enqueue_locked() here because it may be dropped due to buffer size. 
> This is a control token. if it gets dropped, flush() will get stuck forever. 
> 
> not droppable?

How about:
// Push directly in-case we are at logical max capacity, as this must not get dropped

I'm curious now about the fact the buffer size seems only a logical size constraint not an actual out-of-space constraint.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/130