RFR: 8269293: ObjectMonitor thread id fields should be 64 bits.

Coleen Phillimore coleen.phillimore at oracle.com
Thu Jun 24 13:25:56 UTC 2021



On 6/24/21 9:18 AM, David Holmes wrote:
> On Thu, 24 Jun 2021 13:05:04 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>
>> This is a trivial change to fix the type of _previous_version_tid and _notifier_tid in ObjectMonitor to be unint64_t.
>> Tested with tier1-3 and JFR tests on linux-x64-debug and windows-x64-debug.  I don't have a 32 bit system to test this out on.
> Hi Coleen,
>
> Is there any way we can use the JFR type definition "traceid" for this? If not then this looks fine.

Thanks for the quick review.  It's pretty awkward to include 
jfr/support/jfrThreadId.hpp in objectMonitor.hpp (JFR is included 
conditionally), so would have to include these fields conditionally, and 
add #if INCLUDE_JFR in lots of places.  It's not nice.

Thanks,
Coleen

>
> Thanks,
> David
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/4584



More information about the hotspot-runtime-dev mailing list