[jdk17] RFR: 8267952: async logging supports to dynamically change tags and decorators [v2]

[David Holmes]

On Thu, 24 Jun 2021 00:22:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update comments according to reviewers's feedback.
>
> src/hotspot/share/logging/logAsyncWriter.hpp line 133:
> 
>> 131: // flush() is designated to flush out all pending messages. MT-safety is not provided. It is no-op if async logging is not in use.
>> 132: // In normal JVM termination, flush() is invoked in LogConfiguration::finalize(). When the users change logging configurations
>> 133: // via jcmd, LogConfiguration::configure_output() invokes it with the protection of ConfigurationLock.
> 
> Suggestion:
> // flush() ensures that all pending messages have been written out before it returns. It is not MT-safe
> // in itself. When users change the logging configuration via jcmd, LogConfiguration::configure_output()
> // calls flush() under the protection of the ConfigurationLock. In addition flush() is called during JVM
> // termination, via LogConfiguration::finalize, but that occurs during the VM termination safepoint and so
> // no calls to LogConfiguration::configure_output() can be active at the same time.

If you don't want to use my wording at least changed "designated" to "designed" as "designated is the wrong word. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/130