[jdk17] RFR: 8267952: async logging supports to dynamically change tags and decorators [v2]
David Holmes
dholmes at openjdk.java.net
Thu Jun 24 23:48:03 UTC 2021
On Thu, 24 Jun 2021 05:58:54 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> This patch fixed intermittent crashes of gtest/AsyncLogGtest.java. The root cause
>> is that previous flush() can't guarantee flush all pending messages in AsyncLog
>> buffer. This patch implements flush() using a synchronizaton token and waits for
>> completion. This approach isn't MT-safe but it can serialize all flush() calls in
>> a thread.
>>
>> Two concurrent tests are appended to cover the hazard cases.
>> This patch also comments LogConfiguration::configure_output() MT-safety.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>
> Update comments according to reviewers's feedback.
A couple of minor comment nits remain but otherwise this is fine.
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk17/pull/130
More information about the hotspot-runtime-dev
mailing list