[jdk17] RFR: 8267952: async logging supports to dynamically change tags and decorators [v2]

[David Holmes]

On 25/06/2021 10:37 am, Xin Liu wrote:
> On Thu, 24 Jun 2021 05:58:54 GMT, Xin Liu <xliu at openjdk.org> wrote:
> 
>>> This patch fixed intermittent crashes of gtest/AsyncLogGtest.java. The root cause
>>> is that previous flush() can't guarantee flush all pending messages in AsyncLog
>>> buffer. This patch implements flush() using a synchronizaton token and waits for
>>> completion. This approach isn't MT-safe but it can serialize all flush() calls in
>>> a thread.
>>>
>>> Two concurrent tests are appended to cover the hazard cases.
>>> This patch also comments LogConfiguration::configure_output() MT-safety.
>>
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>>    Update comments according to reviewers's feedback.
> 
> hi, @dcubed-ojdk
> Could you try to PR and see if it can solve the two crash sightings?

I already re-ran this through our tier 1-7 testing, running the gtests 
10 times in each configuration they normally run. No failures observed.

David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk17/pull/130
>