RFR: 8269261: The PlaceHolder code uses Thread everywhere but is always dealing with JavaThreads

Calvin Cheung ccheung at openjdk.java.net
Fri Jun 25 02:17:04 UTC 2021


On Fri, 25 Jun 2021 01:00:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this trivial cleanup to change Thread to JavaThread.
> 
> Testing (in progress):
>   - tiers 1-3 sanity check
>   - GHA
> 
> Thanks,
> David

Looks good. Just one nit.

src/hotspot/share/classfile/placeholders.hpp line 120:

> 118:   Symbol*           _supername;
> 119:   JavaThread*           _definer;       // owner of define token
> 120:   InstanceKlass*    _instanceKlass; // InstanceKlass from successful define

Can you align the underscore (_) and "//" with the line below?

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4592


More information about the hotspot-runtime-dev mailing list