RFR: 8269261: The PlaceHolder code uses Thread everywhere but is always dealing with JavaThreads [v2]

Coleen Phillimore coleenp at openjdk.java.net
Fri Jun 25 20:37:08 UTC 2021


On Fri, 25 Jun 2021 02:40:41 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Please review this trivial cleanup to change Thread to JavaThread.
>> 
>> Testing (in progress):
>>   - tiers 1-3 sanity check
>>   - GHA
>> 
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed alignment

Looks good!

src/hotspot/share/classfile/placeholders.cpp line 56:

> 54:    }
> 55:    JavaThread* thread()                const { return _thread;}
> 56:    void set_thread(JavaThread* thread) { _thread = thread; }

Can you line these { up also?

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4592


More information about the hotspot-runtime-dev mailing list