RFR: 8268902: Testing for threadObj != NULL is unnecessary in suspend handshake

David Holmes david.holmes at oracle.com
Fri Jun 25 22:43:10 UTC 2021


On 26/06/2021 3:57 am, Coleen Phillimore wrote:
> In the last pull request on this topic, I was making more general (mis)statements, but this null threadObj check is only for the case where we're suspending a thread which already has a threadObj.  This null check is unnecessary.

This is probably true, but possibly only because we screen out 
jni-attaching threads at a higher-level.

Cheers,
David

> Tested already with tier1-6 (rerun tier1).
> 
> -------------
> 
> Commit messages:
>   - 8268902: Testing for threadObj != NULL is unnecessary in suspend handshake
> 
> Changes: https://git.openjdk.java.net/jdk/pull/4598/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4598&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8268902
>    Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/4598.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/4598/head:pull/4598
> 
> PR: https://git.openjdk.java.net/jdk/pull/4598
> 


More information about the hotspot-runtime-dev mailing list