[jdk17] RFR: 8258746: illegal access to global field _jvmci_old_thread_counters by terminated thread causes crash

David Holmes dholmes at openjdk.java.net
Sat Jun 26 12:23:58 UTC 2021


On Sat, 26 Jun 2021 00:21:26 GMT, Dean Long <dlong at openjdk.org> wrote:

> This change moves the access to the global field _jvmci_old_thread_counters from the thread destructor to JavaThread::exit().  See the JBS issue for more details.  The free of _jvmci_counters is left in the destructor intentionally, as it is allocated in the JavaThread constructor and not all termination paths go through JavaThread::exit().

Hi Dean,

This looks good to me. :)

Good catch on keeping the free of _jvmci_counters in the destructor.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/154


More information about the hotspot-runtime-dev mailing list