[jdk17] RFR: 8267952: async logging supports to dynamically change tags and decorators [v4]
Xin Liu
xliu at openjdk.java.net
Mon Jun 28 05:41:09 UTC 2021
On Fri, 25 Jun 2021 01:22:23 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> This patch fixed intermittent crashes of gtest/AsyncLogGtest.java. The root cause
>> is that previous flush() can't guarantee flush all pending messages in AsyncLog
>> buffer. This patch implements flush() using a synchronizaton token and waits for
>> completion. This approach isn't MT-safe but it can serialize all flush() calls in
>> a thread.
>>
>> Two concurrent tests are appended to cover the hazard cases.
>> This patch also comments LogConfiguration::configure_output() MT-safety.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>
> Update comments part-2.
Hi, Reviewers,
May I have another reviewer to take a look at this? This patch can fix the intermittent crashes for jdk17.
By rules, we need to 2 reviewers to approve it before we can integrate it. David helped me verify it.
thanks,
--lx
-------------
PR: https://git.openjdk.java.net/jdk17/pull/130
More information about the hotspot-runtime-dev
mailing list