RFR: 8269530: runtime/ParallelLoad/ParallelSuperTest.java timeout

David Holmes dholmes at openjdk.java.net
Tue Jun 29 02:48:02 UTC 2021


On Mon, 28 Jun 2021 16:18:00 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Hi,
> 
> Please review this small fix to test ParallelSuperTest.java. I only saw the timeout once on one of my GHA tests but the issue can be easily reproduced by adding a delay in startLoading() before the main thread tries to synchronize on thread_sync.
> Run the test with and without the added delay. The test times out without the patch and passes with the patch.
> 
> Thanks,
> Patricio

Hi Patricio,

The switch to Semaphore looks good. There should never be a use of Object.wait without there being a state variable that controls the wait! Not sure how this got through originally. :(

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4614


More information about the hotspot-runtime-dev mailing list