RFR: 8269615: Fix for 8263640 broke Windows build

Mikael Vidstedt mikael at openjdk.java.net
Tue Jun 29 19:58:02 UTC 2021


On Tue, 29 Jun 2021 19:39:19 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Please review this trivial change for fixing build failure on Windows.
> 
> Testing:
> 
> - [x] windows-x64-debug build
> - [x] tier1 (in progress)

Marked as reviewed by mikael (Reviewer).

src/hotspot/share/runtime/arguments.cpp line 1119:

> 1117:       st->print_raw_cr("<not set>");
> 1118:     } else {
> 1119:       st->print_raw_cr(path, (int)len);

This seems like a reasonable fix.

As a potential follow-up change: I can't help but notice that outputStream::print_raw_cr just delegates to outputStream::write, which takes a size_t argument, so maybe we should align the types?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4626


More information about the hotspot-runtime-dev mailing list