RFR: 8269416: [JVMCI] capture libjvmci crash data to a file [v3]

[David Holmes]

On 30/06/2021 5:17 pm, Doug Simon wrote:
> On Tue, 29 Jun 2021 22:14:50 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> 
>>> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>>
>>>    respect ErrorFileToStdout and ErrorFileToStderr flags
>>
>> Okay. this is fine.
>>
>> Still you need review from Runtime group. I will ping them.
> 
> Thanks for the review David. If it's all the same, I'll keep the ErrorFileToStdOut/Err behavior for this libjvmci error reporting. Looking at the rationale for https://bugs.openjdk.java.net/browse/JDK-8220786, it makes sense for libjvmci error reporting to go to the console when retrieving log files from container environments is problematic. It might even be worth having CI compiler replay respect these flags but that's a separate question that I leave up to @vnkozlov.

No problem. I hadn't seen that you'd made the change when I made the 
comment.

David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/4620
>