RFR: 8262507: OS label and information should be in same line

[Thomas Stüfe]

On Mon, Mar 1, 2021 at 3:57 AM David Holmes <dholmes at openjdk.java.net>
wrote:

> On Mon, 1 Mar 2021 01:29:23 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org>
> wrote:
>
> > We can see OS information in VM.info dcmd and hs_err log as following.
> Most of information and its label are in same line, but just OS is not so.
> >
> > OS:
> >  Windows 10 , 64 bit Build 19041 (10.0.19041.804)
> > OS uptime: 1 days 23:40 hours
> > Hyper-V role detected
> >
> > CPU: total 8 (initial active 8) (8 cores per cpu, 2 threads per core)
> family 23 model 113 stepping 0 microcode 0x0, cx8, cmov, fxsr, ht, mmx,
> 3dnowpref, sse, sse2, sse3, ssse3, sse4a, sse4.1, sse4.2, popcnt, lzcnt,
> tsc, tscinvbit, avx, avx2, aes, clmul, bmi1, bmi2, adx, sha, fma,
> vzeroupper, clflush, clflushopt, hv
> >
> > Memory: 4k page, system-wide physical 16309M (11935M free)
>
> Hi Yasumasa,
>
> Please see my update to the bug report. I do not think this is an issue
> that needs to be "fixed" like this. The "OS:" should act as a sub-heading
> to cover the lines of information that follow. Some fixing of the
> indentation of those following lines is needed.
>
> Thanks,
> David
>

I agree with David here.

A better way to fix this long term may be to make outputStream somehow
"indentation-aware", as in make current indentation a property of the
stream and apply it after every newline. Possibly combined with some sort
of stack based indentation mark. But this may be more difficult than it
sounds due to the somewhat messy outputStream coding. Probably not worth
the effort.

Cheers, Thomas


> -------------
>
> Changes requested by dholmes (Reviewer).
>
> PR: https://git.openjdk.java.net/jdk/pull/2770
>